Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changeset for shortId optimization change #21944

Merged

Conversation

daesunp
Copy link
Contributor

@daesunp daesunp commented Jul 18, 2024

Description

This PR adds a changeset for the change that optimizes Tree.shortId api from this PR

@daesunp daesunp requested a review from a team as a code owner July 18, 2024 17:38
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jul 18, 2024
Comment on lines 6 to 8
Improved performance for accessing identifiers

Identifier field keys are now cached in the schema for faster access to identifiers when calling the Tree.shortId api.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Improved performance for accessing identifiers
Identifier field keys are now cached in the schema for faster access to identifiers when calling the Tree.shortId api.
tree: Improved performance for accessing identifiers in shortId API
Users should see improved performance when calling the `Tree.shortId` API. Identifier field keys are now cached in the schema for faster access.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with suggested change

@tylerbutler tylerbutler changed the title add changeset for shorId optimization change add changeset for shortId optimization change Jul 18, 2024
@daesunp daesunp merged commit 6b4cf26 into microsoft:main Jul 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants