Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: Fix Recursive MapNode d.ts generation #22106

Merged
merged 9 commits into from
Aug 5, 2024

Conversation

CraigMacomber
Copy link
Contributor

Description

Workaround issue where recursive tree schemas using MapNodes produce invalid d.ts files.

See changeset for details.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested review from a team as code owners August 2, 2024 00:28
Copy link

changeset-bot bot commented Aug 2, 2024

🦋 Changeset detected

Latest commit: 434cc29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 157 packages
Name Type
fluid-framework Major
@fluidframework/tree Major
@fluid-example/presence-tracker Major
@fluid-example/inventory-app Major
@fluid-example/app-integration-external-controller Major
@fluid-example/shared-tree-demo Major
@fluid-example/bundle-size-tests Major
@fluid-example/tree-comparison Major
@fluid-example/bubblebench-shared-tree Major
@fluid-internal/tablebench Major
@fluid-example/tree-shim Major
@fluid-experimental/property-shared-tree-interop Major
@fluid-experimental/tree Major
@fluid-experimental/tree-react-api Major
@fluidframework/fluid-telemetry Major
@fluidframework/azure-client Major
@fluidframework/azure-end-to-end-tests Major
@fluid-internal/functional-tests Major
@fluid-private/test-end-to-end-tests Major
@fluidframework/devtools-core Major
@fluid-example/devtools-example Major
@fluid-example/bubblebench-common Major
@fluid-example/bubblebench-experimental-tree Major
@fluid-internal/devtools-browser-extension Major
@fluid-internal/devtools-view Major
@fluidframework/devtools Major
@fluid-example/bubblebench-baseline Major
@fluid-example/bubblebench-ot Major
@fluid-example/attributable-map Major
@fluid-example/collaborative-textarea Major
@fluid-example/contact-collection Major
@fluid-example/data-object-grid Major
@fluid-example/task-selection Major
@fluid-example/odspsnapshotfetch-perftestapp Major
@fluid-example/app-insights-logger Major
@fluid-example/canvas Major
@fluid-example/clicker Major
@fluid-example/codemirror Major
@fluid-example/diceroller Major
@fluid-example/monaco Major
@fluid-example/multiview-constellation-model Major
@fluid-example/multiview-constellation-view Major
@fluid-example/multiview-container Major
@fluid-example/multiview-coordinate-model Major
@fluid-example/multiview-coordinate-interface Major
@fluid-example/multiview-plot-coordinate-view Major
@fluid-example/multiview-slider-coordinate-view Major
@fluid-example/multiview-triangle-view Major
@fluid-example/prosemirror Major
@fluid-example/smde Major
@fluid-example/table-document Major
@fluid-example/todo Major
@fluid-example/webflow Major
@fluid-example/app-integration-external-data Major
@fluid-example/example-utils Major
@fluid-example/webpack-fluid-loader Major
@fluid-example/app-integration-live-schema-upgrade Major
@fluid-example/version-migration-same-container Major
@fluid-example/app-integration-schema-upgrade Major
@fluid-example/app-integration-container-views Major
@fluid-example/app-integration-external-views Major
@fluid-example/view-framework-sampler Major
@fluid-example/property-inspector Major
@fluid-example/schemas Major
@fluid-experimental/azure-scenario-runner Major
@fluid-experimental/property-binder Major
@fluid-experimental/property-changeset Major
@fluid-experimental/property-common Major
@fluid-experimental/property-dds Major
@fluid-experimental/property-inspector-table Major
@fluid-experimental/property-properties Major
@fluid-experimental/property-proxy Major
@fluid-experimental/property-query Major
@fluid-experimental/attributable-map Major
@fluid-experimental/ot Major
@fluid-experimental/sharejs-json1 Major
@fluid-experimental/sequence-deprecated Major
@fluid-experimental/data-objects Major
@fluid-experimental/last-edited Major
@fluid-experimental/ink Major
@fluid-experimental/pact-map Major
@fluid-experimental/attributor Major
@fluid-experimental/data-object-base Major
@fluid-experimental/dds-interceptions Major
@fluid-experimental/oldest-client-observer Major
@fluid-experimental/odsp-end-to-end-tests Major
@fluid-internal/platform-dependent Major
@fluid-internal/client-utils Major
@fluid-internal/local-server-tests Major
@fluid-internal/mocha-test-setup Major
@fluid-internal/test-snapshots Major
@fluid-internal/test-app-insights-logger Major
@fluid-internal/test-driver-definitions Major
@fluid-internal/test-service-load Major
@fluid-internal/replay-tool Major
@fluid-private/test-dds-utils Major
@fluid-private/test-loader-utils Major
@fluid-private/stochastic-test-utils Major
@fluid-private/test-drivers Major
@fluid-private/test-pairwise-generator Major
@fluid-private/test-version-utils Major
@fluid-private/changelog-generator-wrapper Major
@fluid-tools/fetch-tool Major
@fluid-tools/markdown-magic Major
@fluidframework/azure-local-service Major
@fluidframework/azure-service-utils Major
@fluidframework/container-definitions Major
@fluidframework/core-interfaces Major
@fluidframework/core-utils Major
@fluidframework/driver-definitions Major
@fluidframework/cell Major
@fluidframework/counter Major
@fluidframework/map Major
@fluidframework/matrix Major
@fluidframework/merge-tree Major
@fluidframework/ordered-collection Major
@fluidframework/register-collection Major
@fluidframework/sequence Major
@fluidframework/shared-object-base Major
@fluidframework/shared-summary-block Major
@fluidframework/task-manager Major
@fluidframework/debugger Major
@fluidframework/driver-base Major
@fluidframework/driver-web-cache Major
@fluidframework/file-driver Major
@fluidframework/local-driver Major
@fluidframework/odsp-driver-definitions Major
@fluidframework/odsp-driver Major
@fluidframework/odsp-urlresolver Major
@fluidframework/replay-driver Major
@fluidframework/routerlicious-driver Major
@fluidframework/routerlicious-urlresolver Major
@fluidframework/tinylicious-driver Major
@fluidframework/agent-scheduler Major
@fluidframework/aqueduct Major
@fluidframework/app-insights-logger Major
@fluidframework/fluid-static Major
@fluidframework/request-handler Major
@fluidframework/synthesize Major
@fluidframework/undo-redo Major
@fluidframework/container-loader Major
@fluidframework/driver-utils Major
@fluidframework/container-runtime-definitions Major
@fluidframework/container-runtime Major
@fluidframework/datastore-definitions Major
@fluidframework/datastore Major
@fluidframework/id-compressor Major
@fluidframework/runtime-definitions Major
@fluidframework/runtime-utils Major
@fluidframework/test-runtime-utils Major
@fluidframework/odsp-client Major
@fluidframework/tinylicious-client Major
@fluidframework/test-utils Major
@fluidframework/fluid-runner Major
@fluidframework/odsp-doclib-utils Major
@fluidframework/telemetry-utils Major
@fluidframework/tool-utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Aug 2, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Aug 3, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.41 KB 457.44 KB +35 Bytes
azureClient.js 554.57 KB 554.62 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.08 KB 258.09 KB +14 Bytes
fluidFramework.js 408.3 KB 408.31 KB +14 Bytes
loader.js 134.04 KB 134.05 KB +14 Bytes
map.js 42.13 KB 42.14 KB +7 Bytes
matrix.js 146.42 KB 146.42 KB +7 Bytes
odspClient.js 522.72 KB 522.77 KB +49 Bytes
odspDriver.js 97.55 KB 97.57 KB +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB +14 Bytes
sharedString.js 163.14 KB 163.15 KB +7 Bytes
sharedTree.js 398.81 KB 398.82 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: dc9a847

Generated by 🚫 dangerJS against 434cc29

Copy link
Contributor

github-actions bot commented Aug 5, 2024

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Access to these URLs denied by robots.txt, so we couldn't check them:
- https://aka.ms/fluid/devtool
- https://aka.ms/fluid/devtool/chrome
- https://aka.ms/fluid/devtool/edge
- https://aka.ms/fluid/release_blog
- https://aka.ms/fluid/samples
- https://go.microsoft.com/fwlink/?linkid=2259814

http://localhost:1313/docs/api/v1/azure-client/azurefunctiontokenprovider-class/
- (2855:134) 'https://..' => https://github.com/microsoft/FluidFramework/issues/13693 (HTTP 429)
- (2855:134) 'https://..' => https://github.com/microsoft/FluidFramework/issues/13693 (HTTP 429)

http://localhost:1313/docs/api/v1/container-runtime-definitions/idatastorewithbindtocontext_deprecated-interface/
- (2855:30) 'https://..' => https://github.com/microsoft/FluidFramework/issues/9127 (HTTP 429)
- (2855:30) 'https://..' => https://github.com/microsoft/FluidFramework/issues/9127 (HTTP 429)

http://localhost:1313/docs/build/overview/
- (3344:19) '@fluidfr..' => https://www.npmjs.com/package/@fluidframework/azure-client (HTTP 429)

http://localhost:1313/docs/data-structures/sequences/
- (3330:77) 'this git..' => https://github.com/microsoft/FluidFramework/issues/8518 (HTTP 429)


Stats:
  373219 links
    2954 destination URLs
       8 URLs ignored
       0 warnings
       4 errors

 ELIFECYCLE  Command failed with exit code 1.

@CraigMacomber CraigMacomber merged commit 554fc5a into microsoft:main Aug 5, 2024
33 checks passed
@CraigMacomber CraigMacomber deleted the inlineMap branch August 5, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants