Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct settings for compression combinations test #22147

Merged

Conversation

kian-thompson
Copy link
Contributor

A change in compatUtils.ts means that we aren't using the defaults from the ContainerRuntime. Thus, this test isn't actually testing what we want.

This wasn't causing any failures or flaky behavior, but it needed to be corrected.

@kian-thompson kian-thompson requested review from a team, pragya91, markfields, jatgarg, tyler-cai-microsoft and rajatch-ff and removed request for a team August 7, 2024 00:44
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 8e91763

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Aug 7, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.4 KB 457.43 KB +35 Bytes
azureClient.js 554.57 KB 554.61 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.07 KB 258.08 KB +14 Bytes
fluidFramework.js 406.21 KB 406.22 KB +14 Bytes
loader.js 134.04 KB 134.05 KB +14 Bytes
map.js 42.13 KB 42.14 KB +7 Bytes
matrix.js 146.42 KB 146.42 KB +7 Bytes
odspClient.js 522.71 KB 522.76 KB +49 Bytes
odspDriver.js 97.55 KB 97.57 KB +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB +14 Bytes
sharedString.js 163.14 KB 163.15 KB +7 Bytes
sharedTree.js 396.72 KB 396.73 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: c7011bb

Generated by 🚫 dangerJS against 8e91763

@kian-thompson kian-thompson merged commit ffe8248 into microsoft:main Aug 8, 2024
30 checks passed
@kian-thompson kian-thompson deleted the correct-compression-test branch August 8, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants