Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the net Library for IP Type #22405

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

tianzhu007
Copy link
Contributor

@tianzhu007 tianzhu007 commented Sep 5, 2024

Use the net library for IP type detection instead of your custom method. Some IP addresses may not be recognized or printed correctly if you use your own regular expression method.

@github-actions github-actions bot added area: server Server related issues (routerlicious) base: main PRs targeted against main branch labels Sep 5, 2024
@tianzhu007 tianzhu007 changed the title use the net for ip type Use the Net Library for IP Type Sep 5, 2024
@tianzhu007 tianzhu007 changed the title Use the Net Library for IP Type Use the net Library for IP Type Sep 5, 2024
@tianzhu007 tianzhu007 merged commit eaad596 into microsoft:main Sep 6, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Server related issues (routerlicious) base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants