-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Auto-generate and publish release notes for minor releases #22514
ci: Auto-generate and publish release notes for minor releases #22514
Conversation
# Generate release notes | ||
- name: Generate patch release notes | ||
# This content is only for patch releases | ||
if: fromJson(env.RELEASE_JSON).releaseType == 'patch' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this now run for patch releases of anything including Independent packages and server? Also, build-tools used to get this step for every kind of release, now it'll be only for its patch releases, and we're explicitly excluding it from the next step, so there won't be auto-generation of any kind for build-tools minors and majors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this now run for patch releases of anything including Independent packages and server?
Yes. However, I updated it to leave every release except client/server as draft.
Also, build-tools used to get this step for every kind of release, now it'll be only for its patch releases, and we're
explicitly excluding it from the next step, so there won't be auto-generation of any kind for build-tools minors and
majors?
The workflow will fail if the release notes are missing, so I was just going to let them fail. But instead I inverted
the logic from the major/minor releases in this one, so now one of the two steps will be executed on each workflow run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit: the comment on line 117 could go away now, or be copied/hoisted to line 106. But not critical.
The transform:releaseNotes command was added in #22466 to enable automated release note creation for minor releases. This change updates the CI pipeline to take advantage of the new capabilities.
AB#19242