Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree Fix structurally named map and array creation #22522

Merged
merged 6 commits into from
Sep 23, 2024
Merged

tree Fix structurally named map and array creation #22522

merged 6 commits into from
Sep 23, 2024

Conversation

CraigMacomber
Copy link
Contributor

Description

See changeset for details.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested review from a team as code owners September 16, 2024 18:18
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Sep 16, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Sep 17, 2024 •
edited
Loading

⯅ @fluid-example/bundle-size-tests: +317 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.44 KB 460.47 KB ⯅ +35 Bytes
azureClient.js 559.03 KB 559.08 KB ⯅ +49 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 261.68 KB 261.69 KB ⯅ +14 Bytes
fluidFramework.js 403.45 KB 403.5 KB ⯅ +50 Bytes
loader.js 134.17 KB 134.19 KB ⯅ +14 Bytes
map.js 42.43 KB 42.44 KB ⯅ +7 Bytes
matrix.js 145.87 KB 145.88 KB ⯅ +7 Bytes
odspClient.js 526.18 KB 526.23 KB ⯅ +49 Bytes
odspDriver.js 97.8 KB 97.82 KB ⯅ +21 Bytes
odspPrefetchSnapshot.js 42.76 KB 42.78 KB ⯅ +14 Bytes
sharedString.js 162.84 KB 162.84 KB ⯅ +7 Bytes
sharedTree.js 393.92 KB 393.96 KB ⯅ +43 Bytes
Total Size 3.3 MB 3.3 MB ⯅ +317 Bytes

Baseline commit: e7a2f48

Generated by 🚫 dangerJS against f1cc521

@CraigMacomber CraigMacomber changed the title tree Fix structurally named map creation tree Fix structurally named map and array creation Sep 18, 2024
@CraigMacomber CraigMacomber merged commit b3f91ae into microsoft:main Sep 23, 2024
31 checks passed
@CraigMacomber CraigMacomber deleted the mapCreate branch September 23, 2024 19:24
This was referenced Sep 23, 2024
Open
Closed
@tylerbutler tylerbutler mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmithr Josmithr Josmithr approved these changes

Assignees
No one assigned
Labels
area: dds: tree area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CraigMacomber @msfluid-bot @Josmithr