Avoid two leading slashes in the request to create a new file #22563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: driver
aboktor
force-pushed
the
aboktor/sws
branch
from
3287936 to
87b99d1
Compare
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 0b17d50 |
|
@aboktor please make sure you get review and approval from someone on the framework team before merge. |
vladsud
reviewed
Sep 19, 2024
vladsud
approved these changes
Sep 19, 2024
I considered that and decided against it. The safest is to make the change exactly where the leading '/' is being added (which is what I did in this PR). |
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Sep 23, 2024
When using PFT+POP auth with ODSP, ODSP fails to validate the `p` field in the token when we have two leading slashes in the path. This is likely a bug in ODSP but it does result in cryptic 401 failure of the request.
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Sep 23, 2024
When using PFT+POP auth with ODSP, ODSP fails to validate the `p` field in the token when we have two leading slashes in the path. This is likely a bug in ODSP but it does result in cryptic 401 failure of the request.
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Sep 23, 2024
When using PFT+POP auth with ODSP, ODSP fails to validate the `p` field in the token when we have two leading slashes in the path. This is likely a bug in ODSP but it does result in cryptic 401 failure of the request.
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Sep 23, 2024
When using PFT+POP auth with ODSP, ODSP fails to validate the `p` field in the token when we have two leading slashes in the path. This is likely a bug in ODSP but it does result in cryptic 401 failure of the request.
This was referenced Sep 23, 2024
sonalideshpandemsft
added a commit
that referenced
this pull request
Sep 23, 2024
…file (#22563) (#22591) Cherry-pick: #22563 Co-authored-by: Andrew Boktor <[email protected]>
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 23, 2024
…file (#22588) Cherry-pick: #22563 Co-authored-by: Andrew Boktor <[email protected]>
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 23, 2024
…file (#22563) (#22589) Cherry-pick: #22563 Co-authored-by: Andrew Boktor <[email protected]>
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 23, 2024
…file (#22563) (#22590) Cherry-pick: #22563 Co-authored-by: Andrew Boktor <[email protected]>
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using PFT+POP auth with ODSP, ODSP fails to validate the
pfield in the token when we have two leading slashes in the path. This is likely a bug in ODSP but it does result in cryptic 401 failure of the request.Breaking Changes
None
Reviewer Guidance
None