Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: Fix bug with loading detached field index #22680

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

alex-pardes
Copy link
Contributor

Description

Fixed a bug in DetachedFieldIndex.setRevisionsForLoadedData where the newly created DetachedField entries incorrectly had a field named latestRevision instead of latestRelevantRevision.

@alex-pardes alex-pardes requested a review from a team as a code owner September 30, 2024 17:59
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Sep 30, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Sep 30, 2024

@fluid-example/bundle-size-tests: +261 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 461.07 KB 461.11 KB +35 Bytes
azureClient.js 558.69 KB 558.74 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 261.33 KB 261.35 KB +14 Bytes
fluidFramework.js 402.5 KB 402.52 KB +22 Bytes
loader.js 134.17 KB 134.19 KB +14 Bytes
map.js 42.43 KB 42.44 KB +7 Bytes
matrix.js 146.8 KB 146.8 KB +7 Bytes
odspClient.js 525.84 KB 525.89 KB +49 Bytes
odspDriver.js 97.8 KB 97.82 KB +21 Bytes
odspPrefetchSnapshot.js 42.76 KB 42.78 KB +14 Bytes
sharedString.js 163.79 KB 163.8 KB +7 Bytes
sharedTree.js 392.97 KB 392.98 KB +15 Bytes
Total Size 3.3 MB 3.3 MB +261 Bytes

Baseline commit: dc893fe

Generated by 🚫 dangerJS against a770561

@alex-pardes alex-pardes merged commit ecdf26a into microsoft:main Sep 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants