-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree: Cleanup object property tests, and fix bug #22748
Merged
CraigMacomber
merged 3 commits into
microsoft:main
from
CraigMacomber:objectPropertyTests
Oct 8, 2024
Merged
tree: Cleanup object property tests, and fix bug #22748
CraigMacomber
merged 3 commits into
microsoft:main
from
CraigMacomber:objectPropertyTests
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⯅ @fluid-example/bundle-size-tests: +217 Bytes
Baseline commit: 082c72d |
yann-achard-MS
approved these changes
Oct 8, 2024
noencke
approved these changes
Oct 8, 2024
jzaffiro
reviewed
Oct 8, 2024
jzaffiro
approved these changes
Oct 8, 2024
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Oct 9, 2024
## Description This cleans up a section of the object node tests which used schema types in a complicated generic way that's fragile and hard to work with. When rewriting these tests, I focused the new ones on testing aspects that actually have special logic and are likely to break instead of just different value types. Thus the tests now cover the odd normalization cases of numbers. These tests found a couple of issues: - unhydrated node handling of null was incorrect (see changeset) - Some type errors were thrown for invalid user input. TO help keep it easy to tell which errors are our bugs and which are app bugs I've made these fluid usage errors. - A needless check for NaN was included where the check for isFinaite would handle it correctly (Number.isFinite considers NaNs to not be finite: comment already calls out NaN and it has test coverage so this seems like a safe change.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
changeset-present
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleans up a section of the object node tests which used schema types in a complicated generic way that's fragile and hard to work with.
When rewriting these tests, I focused the new ones on testing aspects that actually have special logic and are likely to break instead of just different value types. Thus the tests now cover the odd normalization cases of numbers.
These tests found a couple of issues:
Reviewer Guidance
The review process is outlined on this wiki page.