-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "refactor(telemetry-utlis): Make MockLogger internal" #23035
Conversation
This reverts commit 32ff6b9.
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↑ packages.utils.telemetry-utils.src:
Line Coverage Change: 0.04% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 94.79% | 94.79% | → No change |
Line Coverage | 93.28% | 93.32% | ↑ 0.04% |
Baseline commit: bb64a8e
Baseline build: 305482
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: bb64a8e |
…oft#23035) This reverts commit 25913c7.
## Description Removes the `MockLogger` class from the `@alpha+@legacy` API surface. It has been deprecated for external use since 2024-06-18. Note: originally merged in #23010 and reverted in #23035 because it hadn't been announced previously as part of the breaking changes in 2.10. ## Breaking Changes - `MockLogger` is now removed from the `@alpha+@legacy` API surface, becoming only `@internal`.
Reverts #23010.
Since it wasn't part of the list of removals for 2.10, holding this until 2.20.