-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tree): Add the ability to associate metadata with Node Schema #23321
feat(tree): Add the ability to associate metadata with Node Schema #23321
Conversation
… to json schema domain
Co-authored-by: Noah Encke <[email protected]>
Co-authored-by: Tyler Butler <[email protected]>
|
||
// NOTE that there is currently a bug with the ai-collab library that requires us to rearrange the keys of each type to not have the same first key. | ||
|
||
export class SharedTreeTask extends sf.object("Task", { | ||
title: sf.required(sf.string, { | ||
export class SharedTreeTask extends sf.object( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I've added node-level metadata to these schemas, and fixed some typos. But otherwise, most of these changes are whitespace. If you toggle the "Hide whitespace" option in the GitHub UI, these will be easier to review.
packages/dds/tree/src/simple-tree/api/viewSchemaToSimpleSchema.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good (pending your TODO)!
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Users of TreeView can now specify metadata when creating Node Schema, via
SchemaFactoryAlpha
.This metadata may include system-understood properties like
description
.Example: