Container Rehydration from a snapshot taken from detached container. #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatgarg
added
feature-request
jatgarg
commented
Sep 8, 2020
| this.attached = true; | ||
| } | ||
|
|
||
| private get services() { | ||
| if (this._services === undefined) { |
jatgarg
commented
Sep 8, 2020
| @@ -193,7 +202,7 @@ export class Container extends EventEmitterWithErrorHandling<IContainerEvents> i | |||
| options: any, | |||
| scope: IFluidObject, | |||
| loader: Loader, | |||
| source: IFluidCodeDetails, | |||
| source: DetachedContainerSource, | |||
| serviceFactory: IDocumentServiceFactory, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2692.
Solution:
1.) Loader's createDetachedContainer now takes either iFluidCodeDetails or snapshot. If snapshot is provided, we load from the snapshot.
2.) We keep ripping through the snapshot at container runtime layer and component runtime layer and create local component and channels from the snapshot.
3.) We support delay loading when we load from the snapshot. So when we take the summary for the container to attach, if the component/dds is loaded then we ask them for the summary otherwise we just use the previous summary from which it loaded.
4.) At dds level, we have added a loadLocal api where we load the dds from snapshot but we don't assign it services.
5.) All the components loaded from snapshot are declared as bind but not attached.