-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of error in fetch tool and when to do reauth #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsud
reviewed
Sep 29, 2020
vladsud
reviewed
Oct 1, 2020
vladsud
reviewed
Oct 1, 2020
Ping |
Ping |
heliocliu
reviewed
Oct 15, 2020
packages/drivers/odsp-driver/src/odspDocumentDeltaConnection.ts
Outdated
Show resolved
Hide resolved
heliocliu
reviewed
Oct 15, 2020
heliocliu
reviewed
Oct 15, 2020
heliocliu
reviewed
Oct 15, 2020
heliocliu
reviewed
Oct 15, 2020
heliocliu
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3540
1.) Rename odsp-utils -> odsp-doclib-utils.
2.) Allow odsp-doclib-utils to take dep on driver utils and driver deninitions.
3.) Dedup the code between utils and driver.
4.) Wrong property was read on the error which was created from createErrorFromResponse and because of that we were not going in the reauth flow when the refresh token was expired.