Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of error in fetch tool and when to do reauth #3777

Merged
merged 23 commits into from
Oct 15, 2020

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Sep 29, 2020

Fixes: #3540
1.) Rename odsp-utils -> odsp-doclib-utils.
2.) Allow odsp-doclib-utils to take dep on driver utils and driver deninitions.
3.) Dedup the code between utils and driver.
4.) Wrong property was read on the error which was created from createErrorFromResponse and because of that we were not going in the reauth flow when the refresh token was expired.

@jatgarg jatgarg added bug Something isn't working area: tools labels Sep 29, 2020
@jatgarg jatgarg added this to the September 2020 milestone Sep 29, 2020
@jatgarg jatgarg requested a review from vladsud September 29, 2020 21:46
@jatgarg jatgarg self-assigned this Sep 29, 2020
@jatgarg jatgarg requested a review from vladsud September 29, 2020 22:15
@github-actions github-actions bot requested a review from agarwal-navin October 5, 2020 04:48
@jatgarg
Copy link
Contributor Author

jatgarg commented Oct 6, 2020

Ping

@jatgarg
Copy link
Contributor Author

jatgarg commented Oct 12, 2020

Ping

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 12, 2020

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 174.43 KB 174.43 KB No change
Total Size 174.43 KB 174.43 KB No change

Baseline commit: bf91cd7

Generated by 🚫 dangerJS against f865857

@jatgarg jatgarg requested a review from heliocliu October 15, 2020 06:36
@jatgarg jatgarg merged commit eab218c into microsoft:main Oct 15, 2020
@jatgarg jatgarg deleted the fetchretry branch October 16, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tools bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch-tool fails and incorrectly retries when cached token is expired
5 participants