blob deduping for odsp driver #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinwt
reviewed
Nov 21, 2019
arinwt
reviewed
Nov 21, 2019
packages/drivers/routerlicious-socket-storage/src/documentStorageService.ts
Show resolved
Hide resolved
arinwt
reviewed
Nov 21, 2019
packages/drivers/odsp-socket-storage/src/OdspDocumentStorageManager.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Nov 21, 2019
packages/drivers/odsp-socket-storage/src/OdspDocumentStorageManager.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Nov 21, 2019
packages/drivers/odsp-socket-storage/src/OdspDocumentStorageManager.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Nov 21, 2019
packages/drivers/odsp-socket-storage/src/OdspDocumentStorageManager.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Nov 21, 2019
packages/drivers/odsp-socket-storage/src/OdspDocumentStorageManager.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Nov 21, 2019
packages/drivers/odsp-socket-storage/src/OdspDocumentStorageManager.ts
Outdated
Show resolved
Hide resolved
arinwt
reviewed
Nov 22, 2019
arinwt
reviewed
Nov 22, 2019
packages/drivers/odsp-socket-storage/src/OdspDocumentStorageManager.ts
Outdated
Show resolved
Hide resolved
arinwt
approved these changes
Nov 23, 2019
jatgarg
added a commit
that referenced
this pull request
Nov 23, 2019
* Stop writing duplicated blobs to storage for routerlicious driver. (#592) * stop writing duplicated blobs to storage * change hashing logic * add assert * populate cache with the summary blobs (#626) * populate cache with the summary blobs * add in cache while reading tree * rename * blob deduping for odsp driver (#639) * blob deduping for odsp driver * pr suggestions * update map in get latest * have 2 caches with latest and prev caching * populate cache in blob read * change comment * make map local * make local * local
curtisman
pushed a commit
that referenced
this pull request
Nov 27, 2019
) * Stop writing duplicated blobs to storage for routerlicious driver. (#592) * stop writing duplicated blobs to storage * change hashing logic * add assert * populate cache with the summary blobs (#626) * populate cache with the summary blobs * add in cache while reading tree * rename * blob deduping for odsp driver (#639) * blob deduping for odsp driver * pr suggestions * update map in get latest * have 2 caches with latest and prev caching * populate cache in blob read * change comment * make map local * make local * local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) Use id+path method for specifying the path of the blob in previous summary so as to reuse it.
2.) id is the unacked handle of the previous summary.
3.) So lets say we posted a summary and got back handle x. While specifying path next time for a given blob we will use X/path1/path2 and lets say we get handle Y back. So then next time we will use Y/path1/path2 for the same blob.
4.) Populate the cache on blob reading in get latest.
5.) Update id to path map to get latest so that we does not depend on getTree as we are not sure there that the requested tree is latest or not.