Clean up external-controller dependencies

[ChumpChief]

Starting to look into the dependencies beyond fluid-framework that an author needs to pull in, and saw some opportunity to trim on external-controller.

Most importantly I think app authors should have no server dependencies -- if generateUser() is actually a util that the app author wants, it should probably come from the corresponding client package (e.g. generateAzureUser()). Since generateUser() is not really recommendable (abusing the IUser interface) I just ditched it here.

[heliocliu]

was this example just not using react? 🤔🤔🤔🤔🤔

[ChumpChief]

Yeah I think there were just some leftovers from evolution or copies.

[heliocliu]

we kind of do want a generateUser() method that gives a human readable name (instead of a uuid here). i'd guess it might be useful for a 3rd party developer in some test scenarios as well, so i do think it's worth refactoring

[ChumpChief]

we kind of do want a generateUser() method that gives a human readable name (instead of a uuid here). i'd guess it might be useful for a 3rd party developer in some test scenarios as well, so i do think it's worth refactoring

Yeah I can see that -- my thoughts here were basically:

1. The user needs to end up being service-specific it seems
2. The client packages are where we want to corral service-specific logic, we can't really be service-specific in the shared server packages like @fluidframework/server-services-client
3. Rather than having the helper function return an IUser, the client packages are free to extend IUser however they like and return that from their helper (i.e. like IExtendedUser here in gateway: https://github.com/microsoft/FluidFramework/blob/main/server/gateway/src/routes/utils.ts). So e.g. maybe an IAzureUser and generateTestAzureUser()

In the meantime this retains the same functionality as currently implemented and drops the dependency.