Use real RunningSummarizer in SummaryManager UT to test last summary #7762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
|
@pleath, sorry, somehow I missed this PR. Is it still valid one to pursue? |
|
No worries. I was trying to add some testing of the last-summary logic. I can update it and see if it still passes. :) |
pleath
force-pushed
the
user/pleath/ut-disconnect
branch
from
ad3c834 to
c9ee3f4
Compare
vladsud
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the mock RunningSummarizer class in this UT with a real one, since RunningSummarizer is where the logic to emit a last summary on summarizer close is located. Also adding a test case involving immediate summary when the ops count is very high (> 10K). This test case is simple; more wrinkled ones will be added when a related bug is fixed.