Phase I: Add ICodeDetailsLoader to container-definitions #8478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into code_loader
github-actions
bot
added
area: definitions
area: loader
github-actions
bot
requested review from
vladsud,
curtisman and
anthony-murphy
and removed request for
a team
ChumpChief
approved these changes
Dec 7, 2021
BREAKING.md
Outdated
| @@ -74,6 +75,9 @@ The `maxMessageSize` property from `IConnectionDetails` and `IDocumentDeltaConne | |||
| ### Remove `IntervalCollection.getView()` from sequence dds | |||
| The `IntervalCollection.getView()` was removed. If you were calling this API, you should instead refer to the `IntervalCollection` itself directly in places where you were using the view. | |||
|
|
|||
| ### Added `ICodeDetailsLoader` and `IFluidModuleWithDetails` interface to `@fluidframework/container-definitions` | |||
There was a problem hiding this comment.
Adding isn't a breaking change, but the impending removal from their old location is. Prefer to lead with the breaking info so that customers can easily understand if they need to take action, e.g. "X & Y deprecated in package A, moving to package B".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the
ICodeDetailsLoaderinterface to@fluidframework/container-defintionsand deprecate it from@fluidframework/container-loader.The
@fluidframework/container-definitions/#ICodeLoaderinterface was deprecated and@fluidframework/container-loader/#ICodeDetailsLoaderinterface was introduced to have the abstraction layers separate. But now, to have all the code loading modules in one single package,ICodeLoaderDetailsis being moved to@fluidframework/container-defintions.In future releases,
@fluidframework/container-loader/#ICodeDetailsLoaderwill be removed.Resolves: #8480