Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fluidPackage.ts from core-interface to container-definitions #8486

Merged
merged 16 commits into from
Dec 7, 2021
Merged

Move fluidPackage.ts from core-interface to container-definitions #8486

merged 16 commits into from
Dec 7, 2021

Conversation

sonalivdeshpande
Copy link
Contributor

This PR aims to move fluidPackage.ts from @fluidframework/core-interface to @fluidframework/container-definitions to have all the code loading module in @fluidframework/container-definitions.

fluidPackage.ts from @fluidframework/core-interface is deprecated and would be removed in the future releases.

Resolves: #8485

@sonalivdeshpande sonalivdeshpande requested a review from a team as a code owner December 7, 2021 22:48
@github-actions github-actions bot requested review from vladsud and removed request for a team December 7, 2021 22:48
@github-actions github-actions bot added area: definitions breaking change This PR or issue would introduce a breaking change public api change Changes to a public API labels Dec 7, 2021
@github-actions github-actions bot requested a review from curtisman December 7, 2021 22:48
ChumpChief
ChumpChief approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@ChumpChief ChumpChief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You'll need to merge in latest BREAKING.md

@github-actions github-actions bot removed the request for review from a team December 7, 2021 23:19
@sonalivdeshpande sonalivdeshpande requested a review from a team as a code owner December 7, 2021 23:31
@github-actions github-actions bot removed the request for review from a team December 7, 2021 23:32
@github-actions github-actions bot added the area: dds Issues related to distributed data structures label Dec 7, 2021
@github-actions github-actions bot added area: dds: sharedstring area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc labels Dec 7, 2021
@github-actions github-actions bot removed area: server Server related issues (routerlicious) area: runtime Runtime related issues area: dds Issues related to distributed data structures area: tests Tests to add, test infrastructure improvements, etc area: dds: sharedstring area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct labels Dec 7, 2021
@sonalivdeshpande sonalivdeshpande merged commit 219474d into microsoft:main Dec 7, 2021
@sonalivdeshpande sonalivdeshpande deleted the code_loader branch December 9, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladsud vladsud Awaiting requested review from vladsud

@curtisman curtisman Awaiting requested review from curtisman

@anthony-murphy anthony-murphy Awaiting requested review from anthony-murphy

@skylerjokiel skylerjokiel Awaiting requested review from skylerjokiel

@ChumpChief ChumpChief Awaiting requested review from ChumpChief

Assignees
No one assigned
Labels
area: definitions breaking change This PR or issue would introduce a breaking change public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phase II: Move @fluidframework/core-interface#fluidPackage.ts to @fluidframework/container-definition package
2 participants
@sonalivdeshpande @ChumpChief