-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Storage Name into Tenants Custom Data #9339
Merged
tianzhu007
merged 21 commits into
microsoft:main
from
tianzhu007:Add-Storage-Name-into-Tenants-Custom-Data
Mar 4, 2022
Merged
Add Storage Name into Tenants Custom Data #9339
tianzhu007
merged 21 commits into
microsoft:main
from
tianzhu007:Add-Storage-Name-into-Tenants-Custom-Data
Mar 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianzhu007
assigned pradeepvairamani, tanviraumi, znewton, yangg-msft, hedasilv and arikt-ms
Mar 4, 2022
tanviraumi
approved these changes
Mar 4, 2022
hedasilv
approved these changes
Mar 4, 2022
…ithub.com/tianzhu007/FluidFramework into Add-Storage-Name-into-Tenants-Custom-Data # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
hedasilv
approved these changes
Mar 4, 2022
arikt-ms
reviewed
Mar 4, 2022
arikt-ms
approved these changes
Mar 4, 2022
This was referenced Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on decoupling the r11s service from storage in the azure fluid relay.
We hope to store the storage name per tenant in cosmos DB. We will be using the storage name to store the summaries in the storage that is associated with the tenant.
This is the pr to introduce this storageName variable in the tenant's custom data.