Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Organize and document summarizer telemetry (#9278)" #9492

Closed
wants to merge 1 commit into from

Conversation

pleath
Copy link
Contributor

@pleath pleath commented Mar 15, 2022

Revert this change so it can be reconciled with eslint changes.

@pleath pleath requested review from a team as code owners March 15, 2022 20:25
@github-actions github-actions bot added area: runtime Runtime related issues documentation Improvements or additions to documentation labels Mar 15, 2022
@github-actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast /home/runner/work/FluidFramework/FluidFramework/docs
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt "--external"

Crawling...

Stats:
   13621 links
     283 destination URLs
       1 URLs ignored
       0 warnings
       0 errors


@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +5 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 380.38 KB 380.38 KB +1 Bytes
containerRuntime.js 188.21 KB 188.21 KB +1 Bytes
loader.js 158.81 KB 158.81 KB No change
map.js 203.3 KB 203.3 KB +1 Bytes
matrix.js 290.13 KB 290.13 KB +1 Bytes
odspDriver.js 158.81 KB 158.81 KB No change
odspPrefetchSnapshot.js 45.92 KB 45.92 KB No change
sharedString.js 309.57 KB 309.58 KB +1 Bytes
Total Size 1.73 MB 1.73 MB +5 Bytes

Baseline commit: d9c2724

Generated by 🚫 dangerJS against c60d2c7

@pleath pleath requested a review from ChumpChief March 15, 2022 21:38
@pleath
Copy link
Contributor Author

pleath commented Mar 15, 2022

@ChumpChief is taking care of the eslint whitespace issue. Thanks.

@pleath pleath closed this Mar 15, 2022
@ChumpChief
Copy link
Contributor

Eslint whitespace issue fixed as part of #9493

@taylorsw04 taylorsw04 deleted the user/pleath/revert-telemetry-doc branch June 21, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants