-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the revert of Shared Directory changes and make them non breaking in main #9659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Issues related to distributed data structures
breaking change
This PR or issue would introduce a breaking change
dependencies
Pull requests that update a dependency file
public api change
Changes to a public API
base: main
PRs targeted against main branch
labels
Mar 29, 2022
heliocliu
reviewed
Mar 29, 2022
⯅ @fluid-example/bundle-size-tests: +1.14 KB
Baseline commit: 1d97cdb |
Co-authored-by: Helio Liu <[email protected]>
heliocliu
approved these changes
Mar 29, 2022
github-actions
bot
removed
the
dependencies
Pull requests that update a dependency file
label
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
breaking change
This PR or issue would introduce a breaking change
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) These changes were already merged in main but needed to be reverted as per the decision taken then because it leads to OWH change their implementation of IDirectory.
2.) As per the latest discussion, we can introduce these changes again in non breaking way and mention in upcoming changes.
Previous merged PRs:
#9087 - Add dispose event on directory deletion
#9451 - Emit dispose event recursively