Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the revert of Shared Directory changes and make them non breaking in main #9659

Merged
merged 9 commits into from
Mar 30, 2022

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Mar 29, 2022

1.) These changes were already merged in main but needed to be reverted as per the decision taken then because it leads to OWH change their implementation of IDirectory.
2.) As per the latest discussion, we can introduce these changes again in non breaking way and mention in upcoming changes.

Previous merged PRs:
#9087 - Add dispose event on directory deletion
#9451 - Emit dispose event recursively

@jatgarg jatgarg self-assigned this Mar 29, 2022
@jatgarg jatgarg requested review from msfluid-bot and a team as code owners March 29, 2022 21:27
@jatgarg jatgarg requested a review from andre4i March 29, 2022 21:27
@github-actions github-actions bot added area: dds Issues related to distributed data structures breaking change This PR or issue would introduce a breaking change dependencies Pull requests that update a dependency file public api change Changes to a public API base: main PRs targeted against main branch labels Mar 29, 2022
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Mar 29, 2022

@fluid-example/bundle-size-tests: +1.14 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 381.25 KB 382.39 KB +1.14 KB
containerRuntime.js 189.5 KB 189.5 KB No change
loader.js 158.9 KB 158.9 KB No change
map.js 204.6 KB 204.6 KB No change
matrix.js 292.1 KB 292.1 KB No change
odspDriver.js 182.82 KB 182.82 KB No change
odspPrefetchSnapshot.js 76.73 KB 76.73 KB No change
sharedString.js 311.58 KB 311.58 KB No change
Total Size 1.79 MB 1.79 MB +1.14 KB

Baseline commit: 1d97cdb

Generated by 🚫 dangerJS against b83b6d1

@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Mar 30, 2022
@jatgarg jatgarg merged commit 383ab72 into microsoft:main Mar 30, 2022
@jatgarg jatgarg deleted the directmain branch March 30, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures base: main PRs targeted against main branch breaking change This PR or issue would introduce a breaking change public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants