Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging in runWithRetry when aborted #9761

Merged
merged 5 commits into from
Apr 7, 2022
Merged

Fix logging in runWithRetry when aborted #9761

merged 5 commits into from
Apr 7, 2022

Conversation

chensixx
Copy link
Contributor

@chensixx chensixx commented Apr 6, 2022

Fixes #8309
Fixed how the error is logged and thrown in runWithRetry when it's aborted

@chensixx chensixx requested a review from a team as a code owner April 6, 2022 17:35
@chensixx chensixx requested a review from markfields April 6, 2022 17:35
@github-actions github-actions bot added area: loader Loader related issues base: main PRs targeted against main branch labels Apr 6, 2022
markfields
markfields approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@markfields markfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂 Thanks for the quick follow-up!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Apr 6, 2022 •
edited
Loading

⯆ @fluid-example/bundle-size-tests: -314 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 386.59 KB 386.59 KB ■ No change
containerRuntime.js 193.14 KB 193.14 KB ■ No change
loader.js 159.98 KB 159.68 KB ⯆ -314 Bytes
map.js 208.23 KB 208.23 KB ■ No change
matrix.js 295.68 KB 295.68 KB ■ No change
odspDriver.js 183 KB 183 KB ■ No change
odspPrefetchSnapshot.js 76.72 KB 76.72 KB ■ No change
sharedString.js 315.68 KB 315.68 KB ■ No change
Total Size 1.81 MB 1.81 MB ⯆ -314 Bytes

Baseline commit: 11d8226

Generated by 🚫 dangerJS against e750e22

@chensixx chensixx requested a review from msfluid-bot as a code owner April 7, 2022 17:27
@chensixx chensixx merged commit 6bc6e74 into microsoft:main Apr 7, 2022
@chensixx
Copy link
Contributor Author

chensixx commented Jun 9, 2022

the _runwithRetryAborted events are not making it to logs, need to investigate more

@chensixx chensixx deleted the error branch January 6, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markfields markfields markfields approved these changes

@vladsud vladsud vladsud approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: loader Loader related issues base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
4 participants
@chensixx @msfluid-bot @markfields @vladsud