Move Storage Urls from Tenant Metadata to Service Level #9849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianzhu007
changed the title
tianzhu007
changed the title
tianzhu007
changed the title
znewton
reviewed
Apr 12, 2022
znewton
reviewed
Apr 12, 2022
server/routerlicious/packages/routerlicious-base/src/riddler/runnerFactory.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/packages/routerlicious-base/src/riddler/runnerFactory.ts
Outdated
Show resolved
Hide resolved
hedasilv
reviewed
Apr 12, 2022
There was a problem hiding this comment.
Since we are changing/introducing some configurations in the config.json from Historian and Routerlicious, we will probably also have to update the configmaps for Kubernetes:
Routerlicious:
https://github.com/microsoft/FluidFramework/blob/main/server/routerlicious/kubernetes/routerlicious/templates/fluid-configmap.yaml
tianzhu007
changed the title
hedasilv
reviewed
Apr 13, 2022
server/historian/packages/historian-base/src/services/restGitService.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/packages/routerlicious-base/src/alfred/runnerFactory.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/kubernetes/routerlicious/templates/fluid-configmap.yaml
Outdated
Show resolved
Hide resolved
hedasilv
approved these changes
Apr 13, 2022
server/routerlicious/kubernetes/routerlicious/templates/fluid-configmap.yaml
Outdated
Show resolved
Hide resolved
znewton
approved these changes
Apr 14, 2022
Resolve Conflicts: # server/historian/packages/historian-base/src/routes/utils.ts # server/routerlicious/packages/services/src/tenant.ts
pradeepvairamani
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to map the storage.internalHistorianUrl, and storage.url to each service/cluster, instead of let them be the attributes from the tenant metadata.
Previously, these two urls are based on each tenant. The drawback is that one tenant can be shared by different clusters. These clusters might use different storage.internalHistorianUrls and storage.urls. Thus, the tenant metadata can only store one pair of these urls which cannot satisfy all of the clusters.