Add connect() and disconnect() to IFluidContainer and FluidContainer
#9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
scottn12
commented
Apr 18, 2022
| * {@inheritDoc IFluidContainer.connect} | ||
| */ | ||
| public async connect(): Promise<void> { | ||
| return this.container.connect?.(); |
There was a problem hiding this comment.
The syntax here isn't great. The alternative would be to wait to make these changes once connect()/disconnect() are made mandatory on IContainer. However, I felt it made sense to make the functions mandatory for both IContainer and IFluidContainer in a separate future PR (since they are breaking changes), and then update the syntax here after.
github-actions
bot
removed
area: examples
scottn12
commented
Apr 19, 2022
| "broken": {} | ||
| "broken": { | ||
| "ClassDeclaration_FluidContainer": { | ||
| "forwardCompat": false |
There was a problem hiding this comment.
@heliocliu, I believe this situation is similar to the one in my last PR here. Thoughts on if this is okay to stay in main, or if this PR should be in next?
There was a problem hiding this comment.
this should be fine in main (since i don't think there are any runtime object compatibility considerations here)
heliocliu
approved these changes
Apr 19, 2022
anthony-murphy
pushed a commit
that referenced
this pull request
May 18, 2022
…tainer` (#9947) Add `connect()` and `disconnect()` to `IFluidContainer` and `FluidContainer`. These functions will be made optional on `IFluidContainer` to avoid a breaking change. In a future release these will be made mandatory functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
connect()anddisconnect()toIFluidContainerandFluidContainer. These functions will be made optional onIFluidContainerto avoid a breaking change. In a future release these will be made mandatory functions.Closes #9745