Remove the Discovery Endpoint in the routerliciousTestDriver.ts #9999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hu007/FluidFramework into Enable-Routing-Work-Driver
Resolve Conflicts: # packages/drivers/routerlicious-driver/src/documentServiceFactory.ts
github-actions
bot
added
area: tests
tianzhu007
changed the title
pradeepvairamani
approved these changes
Apr 21, 2022
anthony-murphy
pushed a commit
that referenced
this pull request
May 18, 2022
* FRS-Echo-Openapis-POC * Update openapi.json * Update openapi.json * Upload openapi.yaml * Update openapi.json * Update openapi.json * Update openapi.json * Update openapi.json * Remove openapi * Add the driver side change * Add the typeValidation for driver * Make enableDiscovery and noCacheManger as optional * Add the undefined check for session * Add isCreateContainer flag * Add the "!" * Refactor the urlUtils.ts * Refactor the url methods * Resolve url comments * Change the urls, and add comments * Add the "=" * Merge ISession interfaces for client and server * Remove in document metadata * Revert the change to fix the e2e test * Revert changes in routerliciousTestDriver.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The r11s and frs e2e tests failed after the client-side pr for discovery. We revert the commit to routerliciousTestDriver.ts to let e2e pass through.