implement LWG3320 by deleting const_iterator and const_reverse_iterator

microsoft · Apr 14, 2020 · 7341c5d · 7341c5d
1 parent 044849d
commit 7341c5d
Show file tree

Hide file tree

Showing 6 changed files with 1,234 additions and 1,536 deletions.
diff --git a/include/gsl/span b/include/gsl/span
@@ -403,9 +403,7 @@ public:
     using difference_type = std::ptrdiff_t;
 
     using iterator = details::span_iterator<ElementType>;
-    using const_iterator = details::span_iterator<const ElementType>;
     using reverse_iterator = std::reverse_iterator<iterator>;
-    using const_reverse_iterator = std::reverse_iterator<const_iterator>;
 
 #if defined(GSL_USE_STATIC_CONSTEXPR_WORKAROUND)
     static constexpr const size_type extent{Extent};
@@ -594,31 +592,9 @@ public:
         return {data, endData, endData};
     }
 
-    constexpr const_iterator cbegin() const noexcept
-    {
-        const auto data = storage_.data();
-        return {data, data + size(), data};
-    }
-
-    constexpr const_iterator cend() const noexcept
-    {
-        const auto data = storage_.data();
-        const auto endData = data + storage_.size();
-        return {data, endData, endData};
-    }
-
     constexpr reverse_iterator rbegin() const noexcept { return reverse_iterator{end()}; }
     constexpr reverse_iterator rend() const noexcept { return reverse_iterator{begin()}; }
 
-    constexpr const_reverse_iterator crbegin() const noexcept
-    {
-        return const_reverse_iterator{cend()};
-    }
-    constexpr const_reverse_iterator crend() const noexcept
-    {
-        return const_reverse_iterator{cbegin()};
-    }
-
 #ifdef _MSC_VER
     // Tell MSVC how to unwrap spans in range-based-for
     constexpr pointer _Unchecked_begin() const noexcept { return data(); }