fixed cpplint error about namespace using-directives (#2836)

microsoft · Feb 28, 2020 · 53137e2 · 53137e2
1 parent ad83e8f
commit 53137e2
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/include/LightGBM/tree_learner.h b/include/LightGBM/tree_learner.h
@@ -13,10 +13,10 @@
 
 #include <LightGBM/json11.hpp>
 
-using namespace json11;
-
 namespace LightGBM {
 
+using json11::Json;
+
 /*! \brief forward declaration */
 class Tree;
 class Dataset;

diff --git a/src/boosting/gbdt.h b/src/boosting/gbdt.h
@@ -24,10 +24,10 @@
 #include <LightGBM/json11.hpp>
 #include "score_updater.hpp"
 
-using namespace json11;
-
 namespace LightGBM {
 
+using json11::Json;
+
 /*!
 * \brief GBDT algorithm implementation. including Training, prediction, bagging.
 */

diff --git a/src/io/dataset_loader.cpp b/src/io/dataset_loader.cpp
@@ -13,10 +13,10 @@
 
 #include <LightGBM/json11.hpp>
 
-using namespace json11;
-
 namespace LightGBM {
 
+using json11::Json;
+
 DatasetLoader::DatasetLoader(const Config& io_config, const PredictFunction& predict_fun, int num_class, const char* filename)
   :config_(io_config), random_(config_.data_random_seed), predict_fun_(predict_fun), num_class_(num_class) {
   label_idx_ = 0;

diff --git a/src/treelearner/gpu_tree_learner.h b/src/treelearner/gpu_tree_learner.h
@@ -34,10 +34,10 @@
 #include <boost/compute/container/vector.hpp>
 #include <boost/align/aligned_allocator.hpp>
 
-using namespace json11;
-
 namespace LightGBM {
 
+using json11::Json;
+
 /*!
 * \brief GPU-based parallel learning algorithm.
 */

diff --git a/src/treelearner/serial_tree_learner.h b/src/treelearner/serial_tree_learner.h
@@ -30,9 +30,10 @@
 #include <boost/align/aligned_allocator.hpp>
 #endif
 
-using namespace json11;
-
 namespace LightGBM {
+
+using json11::Json;
+
 /*! \brief forward declaration */
 class CostEfficientGradientBoosting;
 /*!