-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Ability to control the printed messages? #1440
Comments
@Laurae2 |
@Laurae2 any response ? |
Redirecting this way is not possible when the session creation is not controlled by the user (same issue with any server spawning R sessions). |
@Laurae2 got it. However, this require to rewrite the R package, more specifically, the dynamic library used by R. |
Since we closed #1909 I want to add here that any solution needs to be compliant with CRAN's requirements, described there. |
Closed in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature. |
Reopening this one since we have an active PR (#2901) for it |
…#1440, fixes microsoft#1909) (microsoft#2901) * [R-package] started cutting over from custom R-to-C interface to R.h * replaced LGBM_SE with SEXP * fixed error about ocnflicting definitions of length * got linking working * more stuff * eliminated R CMD CHECK note about printing * switched from hard-coded include dir to the one from FindLibR.cmake * cleaned up formatting in FindLibR.cmake * commented-out everything in CI that does not touch R * more changes * trying to get better logs * tried ignoring * added error message to confirm a suspicion * still trying to find R during R CMD CHECK * restore full CI * fixed comment * Update R-package/src/cmake/modules/FindLibR.cmake * changed strategy for finding LIBR_HOME on Windows * Removed 32-bit Windows stuff in FindLibR.cmake * Update R-package/src/cmake/modules/FindLibR.cmake * Update CMakeLists.txt Co-Authored-By: Nikita Titov <[email protected]> * Update CMakeLists.txt Co-Authored-By: Nikita Titov <[email protected]> * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * removed some duplication in cmake scripts * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * added LIBR_CORE_LIBRARY back * small fixes to CMakeLists * simplified FindLibR.cmake * some fixes for windows * Apply suggestions from code review Co-Authored-By: Nikita Titov <[email protected]> * allowed for directly passing LIBR_EXECUTABLE to FindLibR.cmake * reorganized FindLibR.cmake to catch more cases * clean up inconsistencies in R calls in FindLibR.cmake * Update R-package/src/cmake/modules/FindLibR.cmake Co-Authored-By: Nikita Titov <[email protected]> * removed unnecessary log messages * removed unnecessary unset() call Co-authored-by: Nikita Titov <[email protected]>
Currently, LightGBM is not using the R printf message, leading to bypassing any sink (see #513).
An alternative, without losing performance on metric computation, is to return to R the metric values required and have a callback to print the messages.
Currently, we can log the printed messages by using the metric callback. But that's not the best scenario unfortunately (performance wise, especially on large datasets).
Taking 100M observations, training a model and computing AUC on my machine for 10 iterations:
It would be beneficial for logging the performance of the model throughout the training to a file. Such case would be very useful, especially in RStudio Server: if a user is disconnected (for any reason) from the R session, he/she would not be able to get back on RStudio Server until LightGBM finishes training (logging performance would be a great addition).
The text was updated successfully, but these errors were encountered: