Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document cmake+MinGW (fixes #3060) #3078

Merged
merged 1 commit into from
May 13, 2020
Merged

[docs] Document cmake+MinGW (fixes #3060) #3078

merged 1 commit into from
May 13, 2020

Conversation

Laurae2
Copy link
Contributor

@Laurae2 Laurae2 commented May 13, 2020

This PR documents the solution to the issue found on #3060 (workaround of PR #664).

Users should run cmake twice when the compiler is MinGW, because cmake has a one time stopper when it detects MinGW.

This one time stopper was removed from cmake on the following commit: 3421bc6#diff-473c89bfc9641f554ac12d37ebc3d377R61 (version = ???)

This issue also applies to most of R users who use MinGW as the compiler of choice (default of Rtools, and for those modifying the LightGBM installation script to explicitly compile using MinGW).

@Laurae2 Laurae2 added the doc label May 13, 2020
@Laurae2 Laurae2 changed the title Document cmake+MinGW (issue #3060) Document cmake+MinGW (fixes #3060) May 13, 2020
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! And I agree with putting it here, since it isn't R-specific. Thank you!

@jameslamb jameslamb merged commit 42ebb4e into master May 13, 2020
@StrikerRUS StrikerRUS deleted the fix-3060 branch May 13, 2020 16:59
@StrikerRUS StrikerRUS changed the title Document cmake+MinGW (fixes #3060) [docs] Document cmake+MinGW (fixes #3060) May 13, 2020
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 10, 2020
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants