-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [python-package] fix missing import, test that lightgbm can be imported with only required dependencies (fixes #5631) #5632
Conversation
…encies are missing
I initially just pushed the CI changes, and can see that they DO catch the exact error reported in #5631 🎉
And only on the
Now that there's evidence that that check would catch this, I'll push a fix for the specific issue. |
Co-authored-by: José Morales <[email protected]>
Do you think it'd be worth (maybe in a separate PR) to run the tests as well without the required dependencies? It could help us avoid issues like #4638. |
Yeah I think that could be helpful for catching other issues like the one you linked and like #5631! Could you write up an issue describing it? I'd also love to see us take on tests like the following:
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Fixes #5631.
#5271 added an import from
scikit-learn
but didn't add the corresponding empty import incompat.py
to handle the case wherescikit-learn
is not installed.As a result, I believe that using the Python package without
scikit-learn
has been broken for the last 4 months.This PR proposes the following: