Handle invalid threads in Continue #125
Conversation
|
Hi @orablu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
|
||
| _pollThread.RunOperation(() => _debuggedProcess.Continue(thread.GetDebuggedThread())); | ||
| AD7Thread thread = pThread as AD7Thread; | ||
| _pollThread.RunOperation(() => _debuggedProcess.Continue(thread != null ? thread.GetDebuggedThread() : null)); |
There was a problem hiding this comment.
this can just be thread?.GetDebuggedThread();
|
👍 |
|
Thanks! |
|
Hi @orablu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Handle invalid threads in Continue
| AD7Thread thread = (AD7Thread)pThread; | ||
|
|
||
| _pollThread.RunOperation(() => _debuggedProcess.Continue(thread.GetDebuggedThread())); | ||
| AD7Thread thread = pThread as AD7Thread; |
There was a problem hiding this comment.
Might want to add a note here indicating why we are doing this. Something like:
// VS Code currently has a bug where a thread isn't provided in some cases. Work
// around this by allowing null.
VS Code is giving a thread Id of 0 when continuing from async break. Update Continue method to better handle cases where we can't get a debugged thread from the given pThread.