-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data breakpoints in OpenDebugAD7 #1257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise LGTM |
WardenGnaw
approved these changes
Jan 18, 2022
gregg-miskelly
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
DataBreakpointInfo
andSetDataBreakpoints
for OpenDebugAD7's debug session as a part of the Debug Adapter Protocol (DAP).Notes:
IDebugProperty2
s inVariableManager
for lookup by name/VariableReference later to be used for data breakpoints. We can query forIDebugProperty160
on these to useGetDataBreakpointInfo160
.AD7Property.EnumChildren
support filtering with the child's name (specified here with pszNameFilter)BPLT_DATA_STRING
inAD7BreakpointRequest
(returns the proper address/size).Potential problems/things to improve: