Support vaguely named variables in VariableManager's cache #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardenGnaw
approved these changes
Feb 3, 2022
src/OpenDebugAD7/VariableManager.cs
Outdated
|
|
||
| // NOTE: (Frame, Name) -> IDebugProperty2 | ||
| private readonly Dictionary<Tuple<IDebugStackFrame2, string>, IDebugProperty2> m_framesVariables; | ||
| public static string VariableNameFormat = "{0} #{1}"; |
gregg-miskelly
approved these changes
Feb 3, 2022
calgagi
force-pushed
the
dev/cagaglia/dupeVars
branch
from
6c63c9c to
01ff5e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better fix for microsoft/vscode-cpptools#8760
Improves on #1271 by storing duplicate variable names as "{name} #{uniqueNumber}".
So, if you have 2 variables named
a, you would getaanda #2in the variables window.This also simplifies VariableManager's cache into one dictionary.