Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update condition for max version limitation & add package tags #265

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Update condition for max version limitation & add package tags #265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a944c2
Remove the max version limitation & add package tags
YuliiaKovalova Dec 14, 2023
ec2011b
make mechanism for querying all runtime versions optional
YuliiaKovalova Jan 18, 2024
f433d52
fix review comment
YuliiaKovalova Jan 30, 2024
5546567
Fix documentation for the newly added property
YuliiaKovalova Feb 5, 2024
3befa81
Merge branch 'microsoft:main' into dev/ykovalova/remove_detecting_fut…
YuliiaKovalova Feb 5, 2024
a611a2d
Update version.json to 1.7
YuliiaKovalova Feb 5, 2024
0294ff6
Update pull request build for renamed master
YuliiaKovalova Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/MSBuildLocator/DotNetSdkLocationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,6 @@ internal static class DotNetSdkLocationHelper
return null;
}

// Components of the SDK often have dependencies on the runtime they shipped with, including that several tasks that shipped
// in the .NET 5 SDK rely on the .NET 5.0 runtime. Assuming the runtime that shipped with a particular SDK has the same version,
// this ensures that we don't choose an SDK that doesn't work with the runtime of the chosen application. This is not guaranteed
// to always work but should work for now.
if (major > Environment.Version.Major ||
(major == Environment.Version.Major && minor > Environment.Version.Minor))
{
return null;
}

return new VisualStudioInstance(
name: ".NET Core SDK",
path: dotNetSdkPath,
Expand Down
3 changes: 2 additions & 1 deletion src/MSBuildLocator/Microsoft.Build.Locator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@

<Title>MSBuild Locator</Title>
<Description>Package that assists in locating and using a copy of MSBuild installed as part of Visual Studio 2017 or higher or .NET Core SDK 2.1 or higher.</Description>

<PackageTags>msbuildlocator;locator;buildlocator</PackageTags>

<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>1.6.1</PackageValidationBaselineVersion>
</PropertyGroup>
Expand Down
Loading