Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defensive checks to deps.json and runtimeconfig.json predictions #122

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Oct 25, 2024

Based on additional testing I found that *.runtimeconfig.dev.json files are no longer produced as of .NET SDK 6:

  <PropertyGroup Condition="'$(GenerateRuntimeConfigDevFile)' == ''">
    <GenerateRuntimeConfigDevFile>true</GenerateRuntimeConfigDevFile>
    <!-- Post-net6.0, stop generating *.runtimeconfig.dev.json files to reduce probing paths. -->
    <!-- https://github.com/dotnet/sdk/issues/16818 -->
    <GenerateRuntimeConfigDevFile Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '6.0'))">false</GenerateRuntimeConfigDevFile>
  </PropertyGroup>

I added defensive checks everywhere though just in case anything happens to be unexpectedly missing.

@dfederm dfederm merged commit 20f0e97 into main Oct 25, 2024
3 checks passed
@dfederm dfederm deleted the dfederm/depsjson-defensive branch October 25, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant