-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Implicit references from Microsoft.Build.CentralPackageVersions? #21
Comments
Yes I think an new property added to this condition would do: Feel free to test it out and send a PR |
It looks like it will be a bit more complicated than just adding a condition there, since the implicit references end up getting removed completely by the stuff going on in https://github.com/Microsoft/MSBuildSdks/blob/master/src/CentralPackageVersions/Sdk/Sdk.targets#L28-L54 I see what needs to be done though, so I'll try and get a PR ready soon. |
I did end up spending some time on on this, and got it mostly working, but there were some really weird edge cases that I never found time to work through. Does #31 still replace the implicit packages? If so, perhaps it will be easier to change that once 2.0 is ready. |
@bording yeah I decided with v2.0 to just ignore implicit package references. I'll release it today and you can give it a shot. |
Closed via #31 |
Would it be possible to add an option to Microsoft.Build.CentralPackageVersions to exclude the implicit package references from requiring a PackageVersion entry?
I'd prefer to let those be managed automatically as they currently are, but still have the control that Microsoft.Build.CentralPackageVersions provides for all the other packages.
The text was updated successfully, but these errors were encountered: