Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Implicit references from Microsoft.Build.CentralPackageVersions? #21

Closed
bording opened this issue Apr 5, 2018 · 5 comments
Closed
Labels
Feature Request New feature or request

Comments

@bording
Copy link
Contributor

bording commented Apr 5, 2018

Would it be possible to add an option to Microsoft.Build.CentralPackageVersions to exclude the implicit package references from requiring a PackageVersion entry?

I'd prefer to let those be managed automatically as they currently are, but still have the control that Microsoft.Build.CentralPackageVersions provides for all the other packages.

@jeffkl jeffkl added the Feature Request New feature or request label Apr 5, 2018
@jeffkl
Copy link
Contributor

jeffkl commented Apr 5, 2018

Yes I think an new property added to this condition would do:

https://github.com/Microsoft/MSBuildSdks/blob/master/src/CentralPackageVersions/Sdk/Sdk.targets#L92

Feel free to test it out and send a PR

@bording
Copy link
Contributor Author

bording commented Apr 6, 2018

It looks like it will be a bit more complicated than just adding a condition there, since the implicit references end up getting removed completely by the stuff going on in https://github.com/Microsoft/MSBuildSdks/blob/master/src/CentralPackageVersions/Sdk/Sdk.targets#L28-L54

I see what needs to be done though, so I'll try and get a PR ready soon.

@bording
Copy link
Contributor Author

bording commented May 31, 2018

I did end up spending some time on on this, and got it mostly working, but there were some really weird edge cases that I never found time to work through.

Does #31 still replace the implicit packages? If so, perhaps it will be easier to change that once 2.0 is ready.

@jeffkl
Copy link
Contributor

jeffkl commented May 31, 2018

@bording yeah I decided with v2.0 to just ignore implicit package references. I'll release it today and you can give it a shot.

@jeffkl
Copy link
Contributor

jeffkl commented Jun 26, 2018

Closed via #31

@jeffkl jeffkl closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants