Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.0 of central package versions #31

Merged
merged 2 commits into from
May 31, 2018
Merged

Version 2.0 of central package versions #31

merged 2 commits into from
May 31, 2018

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented May 23, 2018

Use <PackageReference Update="" /> instead of <PackageVersion /> because having two lists is hard to get metadata right.

Update README

@jeffkl jeffkl force-pushed the centralpackversionsv2 branch from e283ca7 to 4cf8305 Compare May 24, 2018 20:52
@jeffkl
Copy link
Contributor Author

jeffkl commented May 25, 2018

  1. Brainstorm a better say of handling global references, maybe just DevelopmentDependency="true" in NuGet proper which is a shortcut for PrivateAssets="All and ExcludeAssets="Compile;Runtime"
  2. Figure out how to ship this officially
    a. Can CPS write to Packages.props?
    b. Are NuGet clients involved in any way?
    c. Who would ship the target?

@jeffkl jeffkl force-pushed the centralpackversionsv2 branch from 4cf8305 to fc9ffb5 Compare May 30, 2018 18:21
jeffkl added 2 commits May 30, 2018 15:01
@jeffkl
Version 2.0 of central package versions
6014c84 
Use <PackageReference Update="" /> instead of <PackageVersion /> because having two lists is hard to get metadata right.

Update README
@jeffkl
Set IncludeAssets="Analyzers;Build" for global package references
b45b4d5
@jeffkl jeffkl force-pushed the centralpackversionsv2 branch from 08dc75e to b45b4d5 Compare May 30, 2018 22:01
@bording bording mentioned this pull request May 31, 2018
Closed
@jeffkl jeffkl merged commit 321da5c into microsoft:master May 31, 2018
@jeffkl jeffkl deleted the centralpackversionsv2 branch May 31, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeffkl