Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoTargets] FileWrites has no impact on build incrementalism #422

Closed
stan-sz opened this issue Feb 20, 2023 · 1 comment · Fixed by #423
Closed

[NoTargets] FileWrites has no impact on build incrementalism #422

stan-sz opened this issue Feb 20, 2023 · 1 comment · Fixed by #423
Labels
Documentation Documentation should be improved

Comments

@stan-sz
Copy link
Contributor

stan-sz commented Feb 20, 2023

Taking the repo's example for repro, the items written in FileWrites are created too late for _CleanGetCurrentAndPriorFileWrites to be processed. Is this an issue with the example (fine-tune Before/AfterTargets) or with the NoTargets SDK?

Here's the graphical representation of the order of actions:

image

@jeffkl
Copy link
Contributor

jeffkl commented Feb 21, 2023

Yeah I guess _CleanGetCurrentAndPriorFileWrites runs as part of IncrementalClean which runs as part of CoreBuild and the example runs before AfterBuild. We can update the example to run as part of PrepareForRun instead which is what triggers copying files to the output directory.

<Target Name="CopyFiles" BeforeTargets="PrepareForRun">

Do you want to update the example?

@jeffkl jeffkl added the Documentation Documentation should be improved label Feb 21, 2023
stan-sz added a commit to stan-sz/MSBuildSdks that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation should be improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants