VS Manage NuGet Packages support for CentralPackageVersions

[japj]

When I use the VS buildin Manage NuGet Packages to update package versions, it adds the Version attribute back to the PackageReference instead of modifying the Packages.props file.

This breaks the integration

[jeffkl]

The NuGet team is actively working on this at NuGet/Home#6764

[stevenbrix]

@Jefflk, will there be any value in the Microsoft.Build.CentralPackageVersions MSBuild SDK once the Nuget team adds this support? It looks like they are building the exact same thing (which is good, this should be a feature of Nuget and not something the MSBuild team had to add on)

[jeffkl]

We will most likely deprecate Microsoft.Build.CentralPackageVersions once NuGet has built in support for managing package versions centrally. I have been working with the NuGet team on their implementation and I'll probably work on some tooling to help people migrate.

[jmecosta]

Good to hear! Is there any ETA for it?

…

On Wed, 26 Feb 2020, 18:25 Jeff Kluge, ***@***.***> wrote: We will most likely deprecate Microsoft.Build.CentralPackageVersions once NuGet has built in support for managing package versions centrally. I have been working with the NuGet team on their implementation and I'll probably work on some tooling to help people migrate. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#62?email_source=notifications&email_token=AAH6HSCOLSL255DBC3RZAN3RE2JY5A5CNFSM4GQVQURKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENA474I#issuecomment-591515633>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSCP2YX65ZSOTN3ZNW3RE2JY5ANCNFSM4GQVQURA> .

[jeffkl]

Yes it should be available in Visual Studio 2019 16.6 which is due out in May. Preview versions will have it sooner. It's currently in a feature branch waiting on an MSBuild feature.

[jmecosta]

Alright, thats super good news. Thanks for the update

…

On Wed, 26 Feb 2020, 20:14 Jeff Kluge, ***@***.***> wrote: Yes it should be available in Visual Studio 2019 16.6 which is due out in May. Preview versions will have it sooner. It's currently in a feature branch <https://github.com/NuGet/NuGet.Client/tree/dev-feature-cpvm> waiting on an MSBuild feature <dotnet/msbuild#4975>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#62?email_source=notifications&email_token=AAH6HSBZW5U3XSVIJWITWULRE2WQZA5CNFSM4GQVQURKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENBJNVY#issuecomment-591566551>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6HSHTL3VL4BDBGC5G6CLRE2WQZANCNFSM4GQVQURA> .

[christianbumann]

Yes it should be available in Visual Studio 2019 16.6 which is due out in May. Preview versions will have it sooner. It's currently in a feature branch waiting on an MSBuild feature.

@jeffkl This isn't working for me in Visual Studio Version 16.7. Is there anything I need to consider to get this working properly? I am also not able to find anything in the Visual Studio 16.6 release notes (bug fixes)

[jeffkl]

@christianbumann Are you having problems with our Microsoft.Build.CentralPackageVersions or the NuGet Central Package Version Management? For support on the NuGet solution to central package version management, you'll need to look over at https://github.com/NuGet/Home/issues?q=is%3Aopen+is%3Aissue+label%3AArea%3ARestoreCPVM

[christianbumann]

@christianbumann Are you having problems with our Microsoft.Build.CentralPackageVersions or the NuGet Central Package Version Management? For support on the NuGet solution to central package version management, you'll need to look over at https://github.com/NuGet/Home/issues?q=is%3Aopen+is%3Aissue+label%3AArea%3ARestoreCPVM

@jeffkl Its the Microsoft.Build.CentralPackageVersions. I just tested it with a simple project with following files

project file inside a subfolder. e.g. src\test\test.csproj

<Project Sdk="Microsoft.NET.Sdk.Web">
  <Sdk Name="Microsoft.Build.CentralPackageVersions" Version="2.0.79" />
  <PropertyGroup>
    <TargetFramework>netcoreapp2.1</TargetFramework>
    <OutputType>library</OutputType>
    <PackageId>test</PackageId>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Logging" />
  </ItemGroup>
</Project>

packages.props inside the src folder. e.g. src\packages.props

<?xml version="1.0" encoding="utf-8"?>
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <ItemGroup>
      <PackageReference Update="Microsoft.Extensions.Logging" Version="5.0.0" />
  </ItemGroup>
</Project>

Updating this package with the Visual Studio package manager will update the PackageReference inside the *.csproj instead of the packages.props, and new packages (version) are added to the *.csproj instead of the packages.props.

I'am using VS 16.8.3, not 16.7.3 as mentioned above.

[jeffkl]

@christianbumann sorry for the confusion, Microsoft.Build.CentralPackageVersions is not integrated with Visual Studio and probably never will be. The NuGet team has been working on an integrated solution which shipped in a preview form in 16.6. Their solution will eventually supersede Microsoft.Build.CentralPackageVersions.

For the NuGet implementation, please refer to NuGet/Home#6764

[japj]

@jeffkl with the provided information I think it makes sense that I close this issue in the MSBuildSdk repo, since the MS Roadmap is to have the new NuGet/VS integration handle it (out of scope for this repo)