Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on missing CoW assembly in Artifacts #468

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Fix error on missing CoW assembly in Artifacts #468

merged 3 commits into from
Aug 1, 2023

Conversation

erikmav
Copy link
Collaborator

@erikmav erikmav commented Aug 1, 2023 •
edited
Loading

Declare the CoW package private and explicitly copy its assembly alongside the Artifacts assembly for net472 and netstandard2.0. For #463

jeffkl
jeffkl approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jeffkl
jeffkl reviewed Aug 1, 2023
View reviewed changes
src/Artifacts/version.json Outdated Show resolved Hide resolved
@jeffkl jeffkl merged commit cb88d1e into microsoft:main Aug 1, 2023
@erikmav erikmav deleted the dev/erikmav/fixMissingCoW branch August 1, 2023 20:52
@jeffkl jeffkl mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkl jeffkl jeffkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikmav @jeffkl