-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cargo Build Sdk #599
Add Cargo Build Sdk #599
Conversation
Dev/colecarter/cargobuildsdk
check for presence of cargo.toml instead of cargo.lock
Update with local testing instructions
update typos
typos
clean up
src/CargoBuild/sdk/Sdk.props
Outdated
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<!-- Copy logic to know if managed targets got imported: https://github.com/dotnet/sdk/blob/49002c14cf91ecd08e79d6184dbd4716c005b509/src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.targets#L25-L27 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the comment explain why?
So, is it expected that a cargobuild project would be named "csproj"?
Might have already been discussed, and I don't really use rust, but it seems odd to have build in the name twice. |
Good feedback. We did discuss this a bit. Originally had Rust in the name and |
Fair enough. From an outsider's perspective it seems a little odd - given in the future that an LSP might be available, or you might open a solution including this with VSCode, where better rust integration could be available. Does this only output Nuget packages for libraries, or can it build executables (such that it could be referenced by Aspire)? How does this compare to the Android C++/Java Gradle build project build which is about the closest thing I can think of. Anyway, it looks like you've already thought about this so I'll but out, and leave you to finish this impressive bit of code. |
This sdk adds support for building rust projects with cargo within MSBuild.