Merge pull request #1 from doc352/FixSCAuth

Fixes additional Get-TargetResource calls from SCComplianceCase and SCComplianceSearchAction to use @PSBoundParameters and removes $PSBoundParameters.Clone() from SCComplianceSearchAction
microsoft · Jan 25, 2023 · 60b8b3f · 60b8b3f
2 parents b9223b1 + 5ae1cc6
commit 60b8b3f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_SCComplianceCase/MSFT_SCComplianceCase.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_SCComplianceCase/MSFT_SCComplianceCase.psm1
@@ -387,11 +387,7 @@ function Export-TargetResource
         foreach ($Case in $Cases)
         {
             Write-Host "    GDPR: [$i/$($Cases.Count)] $($Case.Name)" -NoNewline
-            $Params = @{
-                Name       = $Case.Name
-                Credential = $Credential
-            }
-            $Results = Get-TargetResource @Params
+            $Results = Get-TargetResource @PSBoundParameters -Name $Case.Name
             $Results = Update-M365DSCExportAuthenticationResults -ConnectionMode $ConnectionMode `
                 -Results $Results
             $currentDSCBlock = Get-M365DSCExportContentForResource -ResourceName $ResourceName `

diff --git a/...osoft365DSC/DSCResources/MSFT_SCComplianceSearchAction/MSFT_SCComplianceSearchAction.psm1 b/...osoft365DSC/DSCResources/MSFT_SCComplianceSearchAction/MSFT_SCComplianceSearchAction.psm1
@@ -523,17 +523,18 @@ function Export-TargetResource
         foreach ($action in $actions)
         {
             Write-Host "        |---[$i/$($actions.Length)] $($action.Name)" -NoNewline
-            $Params = $PSBoundParameters.Clone()
-            $Params.Action = $action.Action
-            $Params.SearchName = $action.SearchName
+            $Params = @{
+                Action = $action.Action
+                SearchName = $action.SearchName
+            }
 
             $Scenario = Get-ResultProperty -ResultString $action.Results -PropertyName 'Scenario'
 
             if ('RetentionReports' -eq $Scenario)
             {
                 $Params.Action = 'Retention'
             }
-            $Results = Get-TargetResource @Params
+            $Results = Get-TargetResource @PSBoundParameters @Params
             $Results = Update-M365DSCExportAuthenticationResults -ConnectionMode $ConnectionMode `
                 -Results $Results
             $currentDSCBlock = Get-M365DSCExportContentForResource -ResourceName $ResourceName `
@@ -565,7 +566,6 @@ function Export-TargetResource
                 $Params = @{
                     Action     = $action.Action
                     SearchName = $action.SearchName
-                    Credential = $Credential
                 }
 
                 $Scenario = Get-ResultProperty -ResultString $action.Results -PropertyName 'Scenario'
@@ -574,7 +574,7 @@ function Export-TargetResource
                 {
                     $Params.Action = 'Retention'
                 }
-                $Results = Get-TargetResource @Params
+                $Results = Get-TargetResource @PSBoundParameters @Params
                 $Results = Update-M365DSCExportAuthenticationResults -ConnectionMode $ConnectionMode `
                     -Results $Results
                 $dscContent += Get-M365DSCExportContentForResource -ResourceName $ResourceName `