Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSFT_EXOAntiPhishPolicy] Deprecated parameters #1018

Closed
SebastianGoers opened this issue Jan 14, 2021 · 3 comments · Fixed by #1644 or #1645
Closed

[MSFT_EXOAntiPhishPolicy] Deprecated parameters #1018

SebastianGoers opened this issue Jan 14, 2021 · 3 comments · Fixed by #1644 or #1645
Assignees

Comments

@SebastianGoers
Copy link

Details of the scenario you tried and the problem that is occurring

Checking values of the parameters

  • TargetedDomainProtectionAction
  • EnableAntispoofEnforcement

returns $null in DSC (in MSFT_EXOAntiPhishPolicy). Requesting their values in PS returns nothing. Maybe these have been deprecated.

Verbose logs showing the problem

PS C:\Windows\system32> Get-AntiPhishPolicy -Spoof | Format-Table EnableAntiSpoofEnforcement

EnableAntiSpoofEnforcement
--------------------------

which should work according to https://docs.microsoft.com/en-us/powershell/module/exchange/get-antiphishpolicy?view=exchange-ps .

Suggested solution to the issue

Update https://github.com/microsoft/Microsoft365DSC/wiki/EXOAntiPhishPolicy (remove the two properties).

The DSC configuration that is used to reproduce the issue (as detailed as possible)

@SebastianGoers
Copy link
Author

@NikCharlebois : We believe this is related to https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3713 It seems that more parameters are affected by this. We have noted changes at least for:

  • EnableAntispoofEnforcement
  • PhishThresholdLevel
  • TargetedDomainProtectionAction
  • TargetedUserProtectionAction

@NikCharlebois
Copy link
Collaborator

Based on the documentation for the New- cmdlet (https://docs.microsoft.com/en-us/powershell/module/exchange/new-antiphishpolicy?view=exchange-ps) the EnableAntispoofEnforcement parameter seem to have indeed been deprecated. The other 3 however are still available in the cmdlet (New-AntiphishPolicy -?)

I will try to track down more information on this deprecation as we were not made aware, and will push a PR to address this in parallel. Thanks

@NikCharlebois
Copy link
Collaborator

UPDATE: It appears that you are right. Even though the cmdlet's help specifies PhishThresholdLevel, TargetedDomainProtectionAction and TargetedUserProtectionAction that these are not officially supported by the cmdlet. We will be marking them as deprecated in the next release and will remove them from the splatted parameters when calling the New/Set

@NikCharlebois NikCharlebois self-assigned this Feb 10, 2021
NikCharlebois added a commit to NikCharlebois/Microsoft365DSC that referenced this issue Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants