Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Fixes #1677

Merged
merged 3 commits into from
Jan 15, 2022
Merged

Various Fixes #1677

merged 3 commits into from
Jan 15, 2022

Conversation

NikCharlebois
Copy link
Collaborator

Pull Request (PR) description

  • EXORoleAssignmentPolicy
    • Fixed logic to update roles assigned to an existing policy;
      MISC
    • Updated logic for Report generation so that it no longer requires the
      same module version as defined in the configuration installed on the
      system where the report is being generated from.

This Pull Request (PR) fixes the following issues

ykuijs
ykuijs requested changes Jan 14, 2022
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very tiny grammatical error ;-)

ykuijs
ykuijs approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikCharlebois NikCharlebois merged commit 632b3f9 into microsoft:Dev Jan 15, 2022
@NikCharlebois NikCharlebois deleted the Fixes branch January 15, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykuijs ykuijs ykuijs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EXORoleAssignmentPolicy can't set Roles as Arrays as provide in MSFT_EXORoleAssignmentPolicy.psm1
2 participants
@NikCharlebois @ykuijs