IntuneDeviceConfigurationPolicyAndroidOpenSourceProject: Fixed policy assignment retrieval when Id is from other tenant, bogus or null #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR fixes the issue I reported on #3971 where an Id might come from another tenant, or even be null since it's not mandatory, and then it failed retrieving the policy assignment due to that.
While making the tests with this fix I also noted that the CIM instances (in this case Assignments) were not being tested properly and Test-TargetResource always returned $false even when it was correct, so while here I also fixed the compare logic by using the same code already used in several other resources.
This Pull Request (PR) fixes the following issues