Improve PowerShell 7 support #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienTschanz
force-pushed
the
fix/powershell-7-support
branch
from
d18a11e to
033c268
Compare
FabienTschanz
changed the title
NikCharlebois
requested changes
Jul 29, 2024
|
|
||
| ```powershell | ||
| Install-Module PSDesiredStateConfiguration -Force | ||
| Install-Module PSDesiredStateConfiguration -RequiredVersion 2.0.7 -Force |
There was a problem hiding this comment.
I think it's either we add it to the manifest and remove this instruction from here, or leave it out of manifest and keep it here. I am afraid we'll end up having different versions listed in documentation and manifest otherwise.
There was a problem hiding this comment.
Okay, just a moment. Let me rephrase it so we don't have any ambiguity there.
There was a problem hiding this comment.
Updated, now using Update-M365DSCDependencies -Scope AllUsers, which in itself goes to the manifest and installs the module if it isn't found in the current PowerShell 7 session.
There was a problem hiding this comment.
@NikCharlebois Can you please have a look at microsoft/DSCParser#50 as well?
NikCharlebois
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request attempts to improve the support of PowerShell 7, especially the handling of the
PSDesiredStateConfigurationmodule in version 1.0 with the cmdletGet-DscResource. In PowerShell 7, the version 1.0 of this module does not return the DSC resources formatted properly. For this to work properly, the version 2.0.7 must be installed.This PR introduces a new module dependency to
PSDesiredStateConfiguration 2.0.7and installs this one, if PowerShell Core is used. It then loads the cmdlets of this module with the PrefixPwshto make sure no naming conflicts happen with version 1.0.For this prefix to work, the Microsoft365DSC modules using cmdlets of the
PSDesiredStateConfigurationmodule must check which PowerShell version they are running and then use the appropriate cmdlet.This PR depends on microsoft/DSCParser#50 for the best experience.
This Pull Request (PR) fixes the following issues