Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autofromconnector type for Intune EDR Windows10 policy #5254

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

FabienTschanz
Copy link
Collaborator

Pull Request (PR) description

This PR aims to address an issue with the AutoFromConnector value for the ConfigurationPackageType in the IntuneEndpointDetectionAndResponsePolicyWindows10 resource. It throws an error for the empty configuration blob, although that blob must be empty because it will be populated by the Graph endpoint.

This Pull Request (PR) fixes the following issues

@ricmestre
Copy link
Contributor

Sure, let me have a look and I'll let you know.

@ricmestre
Copy link
Contributor

No, unfortunately it still fails with:

"device_vendor_msft_windowsadvancedthreatprotection_configurationtype: Selected option device_vendor_msft_windowsadvancedthreatprotection_configurationtype_autofromconnector with dependent settings doesnt contain required dependent settings. Required dependent settings are device_vendor_msft_windowsadvancedthreatprotection_onboarding_fromconnector"

@FabienTschanz
Copy link
Collaborator Author

Thank you for the feedback, definitely missed the correct property name. Can you try with the latest change? I hope that works now.

@ricmestre
Copy link
Contributor

It sure does 🚀! Bad news is that now I can't test this resource in my dev tenant since the Defender connector can't be setup, oh well life...

Please just don't forget to change the the throw exception you added, use $ConfigurationType instead of $DSCParams.ConfigurationType

@FabienTschanz
Copy link
Collaborator Author

It sure does 🚀! Bad news is that now I can't test this resource in my dev tenant since the Defender connector can't be setup, oh well life...

Please just don't forget to change the the throw exception you added, use $ConfigurationType instead of $DSCParams.ConfigurationType

Silly me, always forgetting stuff you just mentioned a minute ago... Added it 👍

@FabienTschanz FabienTschanz marked this pull request as ready for review October 23, 2024 12:02
@FabienTschanz FabienTschanz changed the title DRAFT: Fix autofromconnector type for Intune EDR Windows10 policy Fix autofromconnector type for Intune EDR Windows10 policy Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntuneEndpointDetectionAndResponsePolicyWindows10: Throws exception if blob is empty
3 participants