-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New resource] TeamsProtectionPolicy #5484
Conversation
@ykuijs I understand why you called it TeamsProtectionPolicy but this is actually an EXO resource, I think it should be renamed to maybe EXOTeamsProtectionPolicy. |
...icrosoft365DSC/DSCResources/MSFT_TeamsProtectionPolicy/MSFT_TeamsProtectionPolicy.schema.mof
Outdated
Show resolved
Hide resolved
Modules/Microsoft365DSC/Examples/Resources/TeamsProtectionPolicy/2-Update.ps1
Outdated
Show resolved
Hide resolved
That was something I was thinking about as well when developing. We have to connect to ExchangeOnline and change the setting there, but the setting is for Teams.......I chose to name it Teams since it is really meant for Teams. @NikCharlebois, what is your opinion on this? |
I use separate app registrations for each workload and they have their separate API permissions/roles, it will be hard to justify my customers which have EXO and Teams workloads why they will need to have one EXO admin for EXO and another one for Teams just because of a single resource. |
True, depends from which angle you look at it. From a management perspective it is confusing that if you want to manage Teams, you have to use Teams resources and a single EXO resource. |
Just checked with Nik. There are more resources like this, where we are following the underlying API in the naming. Will update this resource as well to match the EXO naming. |
Pull Request (PR) description
This PR adds a new resource for TeamsProtectionPolicy
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).