Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New resource] TeamsProtectionPolicy #5484

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

ykuijs
Copy link
Member

@ykuijs ykuijs commented Nov 29, 2024

Pull Request (PR) description

This PR adds a new resource for TeamsProtectionPolicy

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@ricmestre
Copy link
Contributor

@ykuijs I understand why you called it TeamsProtectionPolicy but this is actually an EXO resource, I think it should be renamed to maybe EXOTeamsProtectionPolicy.

@ykuijs
Copy link
Member Author

ykuijs commented Nov 29, 2024

@ykuijs I understand why you called it TeamsProtectionPolicy but this is actually an EXO resource, I think it should be renamed to maybe EXOTeamsProtectionPolicy.

That was something I was thinking about as well when developing. We have to connect to ExchangeOnline and change the setting there, but the setting is for Teams.......I chose to name it Teams since it is really meant for Teams.

@NikCharlebois, what is your opinion on this?

@ricmestre
Copy link
Contributor

I use separate app registrations for each workload and they have their separate API permissions/roles, it will be hard to justify my customers which have EXO and Teams workloads why they will need to have one EXO admin for EXO and another one for Teams just because of a single resource.

@ykuijs
Copy link
Member Author

ykuijs commented Nov 29, 2024

True, depends from which angle you look at it. From a management perspective it is confusing that if you want to manage Teams, you have to use Teams resources and a single EXO resource.

@ykuijs
Copy link
Member Author

ykuijs commented Nov 29, 2024

Just checked with Nik. There are more resources like this, where we are following the underlying API in the naming. Will update this resource as well to match the EXO naming.

@ykuijs ykuijs merged commit cbe4758 into microsoft:Dev Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamsProtectionPolicy: New resource proposal
2 participants