Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty or invalid configuration message #5659

Merged

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

This PR adds a message about an empty parsed content from ConvertTo-DSCObject in Initialize-M365DSCReporting. This is done to improve error visibility when a comparison against an empty or invalid configuration is done, where ConvertTo-DSCObject returns a $null object.

There is also a PR open at the DSCParser repository which outputs the errors during parse: microsoft/DSCParser#59

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@NikCharlebois NikCharlebois merged commit 9280452 into microsoft:Dev Jan 22, 2025
2 checks passed
@FabienTschanz FabienTschanz deleted the feat/report-config-validation branch January 23, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare-M365DSCConfigurations: Export produces configurations that cannot be compared
2 participants