Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add config tags in RPM package for specific files #1349

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

aswatt
Copy link
Contributor

@aswatt aswatt commented Jul 27, 2021

Moves affected files from base_omsagent.data to the specific linux_dpkg.data and linux_rpm.data files, and adds the config tag to the files in linux_rpm.data.

More details about the issue can be found here: https://msazure.visualstudio.com/One/_workitems/edit/9984439/

@aswatt aswatt requested a review from nidhanda as a code owner July 27, 2021 21:33
@hestolz
Copy link
Contributor

hestolz commented Jul 27, 2021

@aswatt what about OMSAuditdPlugin.sh ? This was called out in the ICM but I don't see it anywhere here

@aswatt
Copy link
Contributor Author

aswatt commented Jul 27, 2021

@aswatt what about OMSAuditdPlugin.sh ? This was called out in the ICM but I don't see it anywhere here

@hestolz I was looking through the original data files but I couldn't find anywhere that copied over OMSAuditdPlugin.sh - all the other files were already explicitly specified in base_omsagent.data initially. I didn't want to add it in in case there was some unintended side effects, but if it's not explicitly specified here then theoretically it shouldn't be an issue? The original problem was caused by files explicitly specified in the rpm spec file getting updated, and I can't find a way that this file would be explicitly specified.

@hestolz
Copy link
Contributor

hestolz commented Jul 27, 2021

@aswatt here in the DSC repo. If we don't fix that one customer security tool will still be flagging them and we won't be able to resolve

@aswatt
Copy link
Contributor Author

aswatt commented Jul 27, 2021

@hestolz I'll add the change then to the DSC branch, thank you for finding that!

@aswatt aswatt merged commit 3cbc89b into master Jul 27, 2021
@aswatt aswatt deleted the config-rpm branch July 27, 2021 22:43
simathih pushed a commit that referenced this pull request Jul 28, 2021
simathih pushed a commit that referenced this pull request Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants